ruby: eliminate type Time

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10285:1751a0934488
---------------------------
ruby: eliminate type Time
There is another type Time in src/base class which results in a conflict.

Testing Done

Could you elaborate on why Time is Cycles in some cases and Ticks in others? Is this also fixing up bugs?

Nilay Vaish Aug. 25, 2014, 12:04 p.m. (Aug. 25, 2014, 12:04 p.m.)

No, this patch is not fixing any bugs.  I changed the type of the variable
depending on how it is being used in the rest of the code.  For the files
belonging rubytest, the variable was being assigned curCycle()'s return, so I
used Cycles.  In the CacheRecorder structure, the value that is passed on to the
function addRecord() is the Tick value maintained by the replacement policy.

Andreas Hansson Aug. 25, 2014, 12:16 p.m. (Aug. 25, 2014, 12:16 p.m.)

Thanks for the clarification. In summary I take it Time was used inconsistently. Perhaps it's worth adding a comment in the patch summary before submitting it.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)