Ship It!

src/sim/syscall_emul_buf.hh (Diff revision 1)

Are there classes inheriting from this? If so, gcc 4.7 and beyond will be unhappy about removing the virtual keyword for the destructor.

Show all issues

1. Steve Reinhardt Sept. 24, 2014, 10:16 a.m. (Sept. 24, 2014, 10:16 a.m.)

   There are two classes that derive from this (BufferArg and TypedBufferArg, both below this in the same file).  However, none of the derived classes provides a destructor, so there's no need for a virtual destructor.  I've been compiling with gcc 4.8 and have not seen a warning, I believe because the warning only applies if the base class defines other virtual functions:
   https://gcc.gnu.org/wiki/VerboseDiagnostics#delete-non-virtual-dtor
   
   I actually hesitated a bit before getting rid of this, as you would need to put it back if you did start using these classes polymorphically, so I'm glad to know that gcc will provide a warning in that case.