config: Add a --without-python option to build process

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10435:e2dcb73290fc
---------------------------
config: Add a --without-python option to build process

Add the ability to build libgem5 without embedded Python or the
ability to configure with Python.

This is a prelude to a patch to allow config.ini files to be loaded
into libgem5 using only C++ which would make embedding gem5 within
other simulation systems easier.

This adds a few registration interfaces to things which cross
between Python and C++.  Namely: stats dumping and SimObject resolving

Testing Done

Issue Summary

Description	From	Last Updated	Status
Why not just have one flag called skip_no_python?	Nathan Binkert	Sept. 29, 2014, 6:08 a.m.	Open
Shouldn't you just make it so that SwigSource automatically has the guard?	Nathan Binkert	Sept. 29, 2014, 6:08 a.m.	Open

src/SConscript (Diff revision 1)

Why not just have one flag called skip_no_python?

Show all issues

Andrew Bardsley Sept. 29, 2014, 7:40 a.m. (Sept. 29, 2014, 7:40 a.m.)

I left the swig related and embedded python-related flags separate as I thought it was useful to separate out the two options (and perhaps provide a --without-embedded-python option).  I didn't end up implementing that top level but, as I'd left the skip_no_swig distributed, felt it was useful to keep the two flags.

Andrew Bardsley Oct. 9, 2014, 5:53 a.m. (Oct. 9, 2014, 5:53 a.m.)
```
I've folded the two flags into one. (Patch to follow)
```

src/SConscript (Diff revision 1)

Shouldn't you just make it so that SwigSource automatically has the guard?

Show all issues

Andrew Bardsley Sept. 29, 2014, 7:40 a.m. (Sept. 29, 2014, 7:40 a.m.)

Yes, that would be simpler.  I'll make both this and the above changes.

Andrew Bardsley Oct. 9, 2014, 5:53 a.m. (Oct. 9, 2014, 5:53 a.m.)
```
Done
```

SConstruct (Diff revision 1)

can we indent the second line to align with the open paren, as with the already wrapped readCommand() lines below?

Description:

~		Changeset 10421:79fdc781826a
	~	Changeset 10435:e2dcb73290fc

		config: Add a --without-python option to build process

		Add the ability to build libgem5 without embedded Python or the
		ability to configure with Python.

		This is a prelude to a patch to allow config.ini files to be loaded
		into libgem5 using only C++ which would make embedding gem5 within
		other simulation systems easier.

		This adds a few registration interfaces to things which cross
		between Python and C++. Namely: stats dumping and SimObject resolving

Diff:

Revision 2 (+547 -189)

Show changes

	SConstruct
	src/SConscript
	src/base/statistics.hh
	src/base/statistics.cc
	src/python/SConscript
	src/python/m5/stats/__init__.py
	src/python/swig/pyobject.hh
	src/python/swig/pyobject.cc
	15 more

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 10421:79fdc781826a

Changeset 10435:e2dcb73290fc

Diff:

Status: Closed (submitted)