misc: Use gmtime for conversion to UTC to avoid getenv/setenv
Review Request #2464 - Created Oct. 14, 2014 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10478:8bc1fcad2a8f --------------------------- misc: Use gmtime for conversion to UTC to avoid getenv/setenv This patch changes how we turn time into UTC. Previously we manipulated the TZ environment variable, but this has issues as the strings that are manipulated could be tainted (see e.g. CERT ENV34-C). Now we simply rely on the built-in gmtime function and avoid touching getenv/setenv all together.
All regressions pass, in UK as well as US :-)
Posted (Oct. 20, 2014, 12:36 a.m.)
I take it there are no objections to these minor fixes and will go ahead and push before the end of the day.
