Let other objects set up memory like regions in a KVM VM.
Review Request #2510 - Created Nov. 17, 2014 and submitted
| Information | |
|---|---|
| Gabe Black | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10551:7767dc21318d --------------------------- Let other objects set up memory like regions in a KVM VM.
Issue Summary
7
4
3
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| The returned slot ID should be typedef:ed, or preferably a struct since that would make type checking more reliable. | Andreas Sandberg | Nov. 19, 2014, 8:39 a.m. | Open |
| Would it make sense to rename this to mapMemSlot? In my opinion, that'd be more descriptive. | Andreas Sandberg | Nov. 19, 2014, 8:39 a.m. | Open |
| How about renaming this to unmapMemSlot? | Andreas Sandberg | Nov. 19, 2014, 8:39 a.m. | Open |
| I think this causes problems with some of the officially supported compilers. It's just a hunch, but please check. | Andreas Hansson | Dec. 8, 2014, 6:36 a.m. | Open |
Posted (Nov. 19, 2014, 8:39 a.m.)
-
src/cpu/kvm/vm.hh (Diff revision 1) -
The returned slot ID should be typedef:ed, or preferably a struct since that would make type checking more reliable.
-
src/cpu/kvm/vm.hh (Diff revision 1) -
Would it make sense to rename this to mapMemSlot? In my opinion, that'd be more descriptive.
-
src/cpu/kvm/vm.hh (Diff revision 1) -
Indentation is inconsistent with the rest of the file.
-
src/cpu/kvm/vm.hh (Diff revision 1) -
What's this group comment doing here and where is it terminated?
-
src/cpu/kvm/vm.hh (Diff revision 1) -
How about renaming this to unmapMemSlot?
-
src/cpu/kvm/vm.cc (Diff revision 1) -
Inconsistent indentation.
Overall, I'd prefer this to be an internal API and have some way of notifying the VM through the System instead of allowing objects to poke around directly. See my reply in the email thread for RB #2513.
Review request changed
Updated (Nov. 23, 2014, 6:51 a.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+127 -13) |
Posted (Dec. 3, 2014, 3:35 a.m.)
Ping
Posted (Dec. 3, 2014, 3:42 a.m.)
As this is quite invasive, how broadly would this be used? Also, is there any chance of rather using devices that do not have memory of their own (and rely on the "normal" system memory that is already mapped)?
I'm still not happy with the setupMemSlot()/disableMemSlot() names, but I can't think of any better names atm, so let's go with them for now.
Posted (Dec. 8, 2014, 6:36 a.m.)
-
src/cpu/kvm/vm.cc (Diff revision 2) -
I think this causes problems with some of the officially supported compilers. It's just a hunch, but please check.
