dev: cirrus: Add a simplified device model for the cirrus graphics device.

Information
Submitter:	Gabe Black
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10608:45b160d14246
---------------------------
dev: cirrus: Add a simplified device model for the cirrus graphics device.

All control register accesses are dropped on the floor. If used with KVM, the
frame buffer is set up as a memory like region to keep performance from
tanking. If a VNC server is configured, the buffer is marked dirty once every
simulated 100ms.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Remove? Or add a comment	Andreas Hansson	Dec. 24, 2014, 5:10 p.m.	Resolved
all of these public? Why?	Andreas Hansson	Dec. 24, 2014, 5:10 p.m.	Resolved
Please use getConstPtr	Andreas Hansson	Dec. 24, 2014, 5:10 p.m.	Resolved
Remove? Or add a more elaborate comment	Andreas Hansson	Dec. 24, 2014, 5:10 p.m.	Resolved
Can we not simply check if kvmkvm is nullptr?	Andreas Hansson	Dec. 24, 2014, 5:10 p.m.	Dropped
I am not too fond of this. Can we note make it null or have a NullKVMVM or similar?	Andreas Hansson	Dec. 24, 2014, 5:10 p.m.	Dropped
Rather unfortunate imho.	Andreas Hansson	Dec. 24, 2014, 5:10 p.m.	Dropped
What if we have a scheduled updateEvent?	Andreas Hansson	Dec. 24, 2014, 5:10 p.m.	Resolved

Description:

~		Changeset 10547:84ba24cbd5c0
	~	Changeset 10549:fe3d0e5f7c14

		dev: cirrus: Add a simplified device model for the cirrus graphics device.

		All control register accesses are dropped on the floor. If used with KVM, the
		frame buffer is set up as a memory like region to keep performance from
		tanking. If a VNC server is configured, the buffer is marked dirty once every
		simulated 100ms.
	+
	+
	+
	+	cirrus fixup

Diff:

Revision 2 (+334)

Show changes

	src/dev/Cirrus.py
	src/dev/SConscript
	src/dev/cirrus.hh
	src/dev/cirrus.cc

Description:

~		Changeset 10549:fe3d0e5f7c14
	~	Changeset 10549:3de00460e9a6

		dev: cirrus: Add a simplified device model for the cirrus graphics device.

		All control register accesses are dropped on the floor. If used with KVM, the
		frame buffer is set up as a memory like region to keep performance from
		tanking. If a VNC server is configured, the buffer is marked dirty once every
		simulated 100ms.
-
-
-
-		cirrus fixup

Diff:

Revision 3 (+334)

Show changes

	src/dev/Cirrus.py
	src/dev/SConscript
	src/dev/cirrus.hh
	src/dev/cirrus.cc

Description:

~		Changeset 10549:3de00460e9a6
	~	Changeset 10553:6c662841f2b8

		dev: cirrus: Add a simplified device model for the cirrus graphics device.

		All control register accesses are dropped on the floor. If used with KVM, the
		frame buffer is set up as a memory like region to keep performance from
		tanking. If a VNC server is configured, the buffer is marked dirty once every
		simulated 100ms.

Diff:

Revision 4 (+334)

Show changes

	src/dev/Cirrus.py
	src/dev/SConscript
	src/dev/cirrus.hh
	src/dev/cirrus.cc

Description:

~		Changeset 10553:6c662841f2b8
	~	Changeset 10609:e591eadc0c63

		dev: cirrus: Add a simplified device model for the cirrus graphics device.

		All control register accesses are dropped on the floor. If used with KVM, the
		frame buffer is set up as a memory like region to keep performance from
		tanking. If a VNC server is configured, the buffer is marked dirty once every
		simulated 100ms.

Diff:

Revision 5 (+345)

Show changes

	src/dev/Cirrus.py
	src/dev/SConscript
	src/dev/cirrus.hh
	src/dev/cirrus.cc

Description:

~		Changeset 10609:e591eadc0c63
	~	Changeset 10609:07584c650657

		dev: cirrus: Add a simplified device model for the cirrus graphics device.

		All control register accesses are dropped on the floor. If used with KVM, the
		frame buffer is set up as a memory like region to keep performance from
		tanking. If a VNC server is configured, the buffer is marked dirty once every
		simulated 100ms.

Diff:

Revision 6 (+340)

Show changes

	src/dev/Cirrus.py
	src/dev/SConscript
	src/dev/cirrus.hh
	src/dev/cirrus.cc

src/dev/Cirrus.py (Diff revision 6)

Remove? Or add a comment

Show all issues

src/dev/cirrus.hh (Diff revision 6)

all of these public? Why?

Show all issues

src/dev/cirrus.cc (Diff revision 6)

Please use getConstPtr

Show all issues

src/dev/cirrus.cc (Diff revision 6)

Remove? Or add a more elaborate comment

Show all issues

src/dev/cirrus.cc (Diff revision 6)

Can we not simply check if kvmkvm is nullptr?

Show all issues

src/dev/cirrus.cc (Diff revision 6)

I am not too fond of this. Can we note make it null or have a NullKVMVM or similar?

Show all issues

src/dev/cirrus.cc (Diff revision 6)

Rather unfortunate imho.

Show all issues

src/dev/cirrus.cc (Diff revision 6)

What if we have a scheduled updateEvent?

Show all issues

src/dev/Cirrus.py (Diff revision 6)

Remove, I think.

src/dev/cirrus.hh (Diff revision 6)

They probably shouldn't be. I'll fix that.

Gabe Black Dec. 22, 2014, 4:56 p.m. (Dec. 22, 2014, 4:56 p.m.)
```
These default to private, but I'll make that explicit.
```

src/dev/cirrus.cc (Diff revision 6)

Ok.

src/dev/cirrus.cc (Diff revision 6)

I don't know what's going on here. This device model was originally written by someone else, and I added a small fix patch on top of it recently. I'll need to look into what this is for.

src/dev/cirrus.cc (Diff revision 6)

Since USE_KVM is constant at compile time, this if will get compiled away if it's false. We could check kvmVM only, but it would be slightly less efficient. That's probably ok, though.

src/dev/cirrus.cc (Diff revision 6)

Unfortunately no. We can't have the kvmVM parameter in the SimObject if KVM isn't available because we won't have access to that type. In that case, p->kvmVM won't compile.

src/dev/cirrus.cc (Diff revision 6)

It's const everywhere else, we just need to un-constify it here so we can set it up initially.

src/dev/cirrus.cc (Diff revision 6)

Yeah, we should deschedule that.

Description:

~		Changeset 10609:07584c650657
	~	Changeset 10608:7a321b7e3dac

		dev: cirrus: Add a simplified device model for the cirrus graphics device.

		All control register accesses are dropped on the floor. If used with KVM, the
		frame buffer is set up as a memory like region to keep performance from
		tanking. If a VNC server is configured, the buffer is marked dirty once every
		simulated 100ms.

Diff:

Revision 7 (+340)

Show changes

	src/dev/Cirrus.py
	src/dev/SConscript
	src/dev/cirrus.hh
	src/dev/cirrus.cc

Description:

~		Changeset 10608:7a321b7e3dac
	~	Changeset 10608:7c8363f44c5b

		dev: cirrus: Add a simplified device model for the cirrus graphics device.

		All control register accesses are dropped on the floor. If used with KVM, the
		frame buffer is set up as a memory like region to keep performance from
		tanking. If a VNC server is configured, the buffer is marked dirty once every
		simulated 100ms.

Diff:

Revision 8 (+341)

Show changes

	src/dev/Cirrus.py
	src/dev/SConscript
	src/dev/cirrus.hh
	src/dev/cirrus.cc

Looks fine. Could you mark the issues that are fixed as fixed (or dropped for that matter)?

Thanks.

I am still not sure if I like the USE_KVM better, or perhaps having a NullKvm object.

Gabe Black Dec. 24, 2014, 5:09 p.m. (Dec. 24, 2014, 5:09 p.m.)

Yeah. There was one other mistake I noticed which I'm fixing. I'm not going to push this until I get back into the office after New Years and can actually test it.

Description:

~		Changeset 10608:7c8363f44c5b
	~	Changeset 10608:45b160d14246

		dev: cirrus: Add a simplified device model for the cirrus graphics device.

		All control register accesses are dropped on the floor. If used with KVM, the
		frame buffer is set up as a memory like region to keep performance from
		tanking. If a VNC server is configured, the buffer is marked dirty once every
		simulated 100ms.

Diff:

Revision 9 (+341)

Show changes

	src/dev/Cirrus.py
	src/dev/SConscript
	src/dev/cirrus.hh
	src/dev/cirrus.cc

Diff:

Revision 10 (+15 -5)

Show changes

configs/common/FSConfig.py

Rebased diff.

Is there any value in making it conditional?

You have a pending review.

Review Board 2.0.15

Screenshots

Files

Issue Summary

Description:

Changeset 10547:84ba24cbd5c0

Changeset 10549:fe3d0e5f7c14

Diff:

Description:

Changeset 10549:fe3d0e5f7c14

Changeset 10549:3de00460e9a6

Diff:

Description:

Changeset 10549:3de00460e9a6

Changeset 10553:6c662841f2b8

Diff:

Description:

Changeset 10553:6c662841f2b8

Changeset 10609:e591eadc0c63

Diff:

Description:

Changeset 10609:e591eadc0c63

Changeset 10609:07584c650657

Diff:

Description:

Changeset 10609:07584c650657

Changeset 10608:7a321b7e3dac

Diff:

Description:

Changeset 10608:7a321b7e3dac

Changeset 10608:7c8363f44c5b

Diff:

Description:

Changeset 10608:7c8363f44c5b

Changeset 10608:45b160d14246

Diff:

Diff: