x86: i8042: Add VNC mouse support, and flesh out the mouse model.

Information
Submitter:	Gabe Black
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10555:a13dc3596e45
---------------------------
x86: i8042: Add VNC mouse support, and flesh out the mouse model.

This change fleshes out the mouse model so that it can send mouse data to the
simulated system somewhat realistically, and hooks it into the VNC server as
the mouse input device.

Testing Done

Issue Summary

Description	From	Last Updated	Status
I know it is not changed, but could you elaborate on the unit?	Andreas Hansson	Dec. 17, 2014, 5:53 a.m.	Open
const?	Andreas Hansson	Dec. 17, 2014, 5:53 a.m.	Open
const?	Andreas Hansson	Dec. 17, 2014, 5:53 a.m.	Open
, _space_	Andreas Hansson	Dec. 17, 2014, 5:53 a.m.	Open
For the body of this, could you elaborate on why it looks the way it does? At the moment it ...	Andreas Hansson	Dec. 17, 2014, 5:53 a.m.	Open
setMouseAt?	Andreas Hansson	Dec. 17, 2014, 5:53 a.m.	Open

I should add a Google copyright to this...

Description:

~		Changeset 10554:5938f3b53a7d
	~	Changeset 10555:a13dc3596e45

		x86: i8042: Add VNC mouse support, and flesh out the mouse model.

		This change fleshes out the mouse model so that it can send mouse data to the
		simulated system somewhat realistically, and hooks it into the VNC server as
		the mouse input device.

Diff:

Revision 2 (+187 -18)

Show changes

	src/dev/x86/I8042.py
	src/dev/x86/i8042.hh
	src/dev/x86/i8042.cc

src/dev/x86/i8042.hh (Diff revision 2)

I know it is not changed, but could you elaborate on the unit?

Show all issues

Gabe Black Dec. 18, 2014, 2:47 a.m. (Dec. 18, 2014, 2:47 a.m.)

I'll have to look at it again to figure out what the unit is, but yeah, that seems reasonable.

src/dev/x86/i8042.cc (Diff revision 2)

const?

Show all issues

Gabe Black Dec. 18, 2014, 2:47 a.m. (Dec. 18, 2014, 2:47 a.m.)
```
No, because writeData sets state.
```

src/dev/x86/i8042.cc (Diff revision 2)

const?

Show all issues

Gabe Black Dec. 18, 2014, 2:47 a.m. (Dec. 18, 2014, 2:47 a.m.)
```
Nope. statusReg is modified.
```

src/dev/x86/i8042.cc (Diff revision 2)

, _space_

Show all issues

Gabe Black Dec. 18, 2014, 2:47 a.m. (Dec. 18, 2014, 2:47 a.m.)
```
Yep. I'll fix that.
```

src/dev/x86/i8042.cc (Diff revision 2)

For the body of this, could you elaborate on why it looks the way it does? At the moment it is very thin on comments

Show all issues

Gabe Black Dec. 18, 2014, 2:47 a.m. (Dec. 18, 2014, 2:47 a.m.)
```
Yes.
```

src/dev/x86/i8042.cc (Diff revision 2)

setMouseAt?

Show all issues

Gabe Black Dec. 18, 2014, 2:47 a.m. (Dec. 18, 2014, 2:47 a.m.)

I believe that's part of the VNC interface which is defined outside this device.

Looks good, some minor things

You have a pending review.

Review Board 2.0.15

Screenshots

Files

Issue Summary

Description:

Changeset 10554:5938f3b53a7d

Changeset 10555:a13dc3596e45

Diff: