Review Board 2.0.15


x86: i8042: Add VNC keyboard input support.

Review Request #2520 - Created Nov. 22, 2014 and updated

Information
Gabe Black
gem5
default
Reviewers
Default 
Changeset 10556:76e90695e93b
---------------------------
x86: i8042: Add VNC keyboard input support.

This fixes up and fleshes out the keyboard model within the i8042 so that it
can return keyboard input realistically enough to satisfy the kernel.

One notable change was to turn off the convertScanCodes bit. That bit
basically enables a compatibility mode which makes the keyboard return
scancodes from set 1 which the XT computer used. We want to turn off that
translation so that we get scancode set 2, the standard set which was used by
the AT computer. That's also what the existing X11 keycode => scancode
function developed for ARM returns.


   

  


 


 

  

  






 
 
Issue Summary

 

  

   
    
    1
   
   
    
    1
   
   
    
    0
   
   
    
    0
   
  

  

   

    
    
   

   

    
    
   

  

 

 

  

   
    

     Description
     From
     Last Updated
     Status
    

   
   

















    

     for (auto& k : keys) bufferData(&k, 1)
     Andreas Hansson
     Nov. 26, 2014, 2:49 a.m.
     Open
    








   
  

 









  
 


  

 


















 

  


 


  




   
Ship it!



   

   
Nilay Vaish

   
Posted  (Nov. 25, 2014, 2:30 p.m.)


  


  


  

   
Seems fine.



  

   

   
    
    
   


  





  

 


  

 

















 



 

  


 


  



   

   
Andreas Hansson

   
Posted  (Nov. 26, 2014, 2:49 a.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/dev/x86/i8042.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
for (auto& k : keys)
   bufferData(&k, 1)


     





 

  
  
  
  
  
  Show all issues
 




     




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    What is this sorcery? :-) Seriously though, what's this from? Does gcc 0.1 or whatever minimum version we support handle that?
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    c++ 11

And yes, gcc 4.6 supports range-based for loops.

Welcome to the future...if you are so inclined :-)
    
    
    
   
    3. 

   


  


    


   



   
I would suggest "x86, dev" as the keyword(s)