config: Add two options for setting the kernel command line.

Information
Submitter:	Gabe Black
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10561:b2a85a0c0571
---------------------------
config: Add two options for setting the kernel command line.

Both options accept template which will, through python string formatting,
have "mem", "disk", and "script" values substituted in from the mdesc.
Additional values can be used on a case by case basis by passing them as
keyword arguments to the fillInCmdLine function. That makes it possible to
have specialized parameters for a particular ISA, for instance.

The first option lets you specify the template directly, and the other lets
you specify a file which has the template in it.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Should we make this function a part of SysConfig class?	Nilay Vaish	Nov. 30, 2014, 10:38 a.m.	Open

I do not see much value though, but I am fine with patch.

Gabe Black Dec. 1, 2014, 2:43 a.m. (Dec. 1, 2014, 2:43 a.m.)

The ChromeOS kernel needs lots of command line arguments, both to configure the kernel and to leave information for the system at large. This is so we don't have to have a custom hack on top of the config scripts to jam those in there.

I would really, really like to see the config stuff modularized way more than it is now, so that it's realistic to create a different config script which reuses the checked in code instead of having to modify it in place.

Gabe Black Dec. 3, 2014, 3:12 a.m. (Dec. 3, 2014, 3:12 a.m.)
```
Should this go in then?
```

configs/common/FSConfig.py (Diff revision 1)

Should we make this function a part of SysConfig class?

Show all issues

Gabe Black Dec. 1, 2014, 2:43 a.m. (Dec. 1, 2014, 2:43 a.m.)

I can see why you'd say that, but I don't think so right now. It's true that it primarily applies values from the SysConfig class, but that was mostly a coincidence of how things are implemented. If we want to add a new parameter which comes from somewhere else, it would be odd to pass that to a function on the SysConfig. If you were to say that that parameter should be in SysConfig in that case, I'd believe that argument. But I'm still just on the other side of the fence.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)