x86: Add a cirrus graphics adapter to x86 systems.
Review Request #2525 - Created Nov. 23, 2014 and updated
| Information | |
|---|---|
| Gabe Black | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10562:ee3ae920f5b5 --------------------------- x86: Add a cirrus graphics adapter to x86 systems. This required reworking how the functions which hook up the system are organized slightly. They really need more a more substantial overhaul, but that's outside of the scope of this change.
Seems fine... Anyone who deals with Ruby OK?
Posted (Sept. 3, 2015, 3:26 p.m.)
Rebased diff.
Posted (Sept. 4, 2015, 10:23 a.m.)
Looks good other than the one minor thing below.
-
src/dev/cirrus.cc (Diff revision 2) -
How about
kvmVM(USE_KVM ? p->kvmVM : NULL),
I guess kids these days are using nullptr rather than NULL as well
Posted (Sept. 4, 2015, 10:26 a.m.)
sorry, one more thing
-
src/dev/cirrus.hh (Diff revision 2) -
should have a comment here describing the class (details about specific device being emulated etc. would be nice)