Review Board 2.0.15


config: ruby: Get rid of an "eval" and an "exec" operating on generated code.

Review Request #2527 - Created Nov. 23, 2014 and updated

Information
Gabe Black
gem5
default
Reviewers
Default
Changeset 10564:b90448378de5
---------------------------
config: ruby: Get rid of an "eval" and an "exec" operating on generated code.

We can get the same result using importlib.

   
Review request changed
Updated (Nov. 23, 2014, 11:35 a.m.)

Status: Re-opened

Posted (Nov. 23, 2014, 11:37 a.m.)
Looks like importlib is only available in 2.7 (https://docs.python.org/2/library/importlib.html), and according to http://gem5.org/Dependencies we still support 2.5 and 2.6 as well.  Is that accurate?  In isolation, this seems reasonable, but it doesn't seem like enough of an advantage to justify bumping our minimum supported version.
  1. Yes, that seems to be right. I hadn't considered python versions. Today isn't a gem5 day for me (1 workday day a week, weekends if I'm so inclined), so please feel free to revert if it's urgent.