sim: Ensure GDB interrupts the simulation at an instruction boundary.

Information
Submitter:	Gabe Black
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10568:140bd3e1bbc7
---------------------------
sim: Ensure GDB interrupts the simulation at an instruction boundary.

Use the comInstEventQueue to ensure GDB interrupts the simulation at an
instruction boundary and not in the middle of a macroop, memory access, etc.

Testing Done

Just minor stuff, no need to repost IMO

src/base/remote_gdb.cc (Diff revision 1)

date?

Gabe Black Dec. 5, 2014, 1:46 a.m. (Dec. 5, 2014, 1:46 a.m.)
```
Fixed.
```

src/base/remote_gdb.cc (Diff revision 1)

I could use a comment here reminding me that, despite the names, this event is actually scheduled for the next committed instruction and not the next tick

Gabe Black Dec. 5, 2014, 1:46 a.m. (Dec. 5, 2014, 1:46 a.m.)
```
Yep, that's a good idea. Done.
```

src/base/remote_gdb.hh (Diff revision 1)

I'd be tempted to rename the other Event class rather than have to disambiguate here, but I understand if you don't want to be that invasive

Gabe Black Dec. 5, 2014, 1:42 a.m. (Dec. 5, 2014, 1:42 a.m.)

That seems like a good idea, but I'll do it in a later commit to keep from muddying what's going on in this one.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)