arm: Add unlinkat syscall implementation

Information
Submitter:	mike upton
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

arm: Add unlinkat syscall implementation

added ARM aarch64 unlinkat syscall support, modeled on other <xxx>at syscalls.
This gets all of the cpu2006 int workloads passing in SE mode on aarch64.

hmmer, omnetpp

Testing Done

build/ARM/tests/opt/quick/se

SPEC CPU2006 integer apps, test and train input sizes

Issue Summary

Description	From	Last Updated	Status
How will the compiler choose between the two versions of unlinkFunc? I think we should either drop the default argument ...	Nilay Vaish	Dec. 4, 2014, 5:16 p.m.	Resolved
The parameters on the second line need to be aligned with ones in the first line.	Nilay Vaish	Dec. 4, 2014, 2:03 p.m.	Resolved
Parameter needs to be aligned,	Nilay Vaish	Dec. 4, 2014, 2:03 p.m.	Resolved

Ship It!

src/sim/syscall_emul.hh (Diff revision 1)

How will the compiler choose between the two versions of unlinkFunc?  I think we should either drop the default argument or drop the second version.

Show all issues

mike upton Dec. 4, 2014, 2:04 p.m. (Dec. 4, 2014, 2:04 p.m.)

I just copied other instances of similar functionality.


My understanding is the compiler knows which to use because of the parameter count passed in.

I am happy to remove the 4 parameter version, but it will take me a bit to code and test it.

Ali Saidi Dec. 4, 2014, 2:50 p.m. (Dec. 4, 2014, 2:50 p.m.)

The 4 parameter version can't be removed because SyscallDesc requires a function pointer that has four parameters. That is why this version gets called and otherwise the 5 parameter version is used. The default parameter for the 5 parameter version could probably be removed, but removing the 4 parameter version would required templetizing SyscallDesc to support 4 and 5 parameter functions or changing all sys call functions to require 5 parameters.

mike upton Dec. 4, 2014, 5:17 p.m. (Dec. 4, 2014, 5:17 p.m.)

Steve suggested changing the name of the 5 element func to unlinkHelper.
I did that. Let me know if I should update the other syscall routines in a similar fashion.

Steve Reinhardt Dec. 5, 2014, 9:46 a.m. (Dec. 5, 2014, 9:46 a.m.)

I think that's a great idea and I'd really appreciate it.  Then again, it's my idea, so I'm biased about it...

src/sim/syscall_emul.hh (Diff revision 1)

The parameters on the second line need to be aligned with ones in the first line.

Show all issues

src/sim/syscall_emul.cc (Diff revision 1)

Parameter needs to be aligned,

Show all issues

Change Summary:

fixed the two indenting issues

Diff:

Revision 2 (+25 -2)

Show changes

	src/arch/arm/linux/process.cc
	src/sim/syscall_emul.hh
	src/sim/syscall_emul.cc

Change Summary:

Renamed 5 element function to unlinkHelper

Diff:

Revision 3 (+25 -2)

Show changes

	src/arch/arm/linux/process.cc
	src/sim/syscall_emul.hh
	src/sim/syscall_emul.cc

Ship It!

mike upton Dec. 29, 2014, 10:57 a.m. (Dec. 29, 2014, 10:57 a.m.)
```
Is there something blocking this change?
```
Andreas Hansson Dec. 29, 2014, 2:24 p.m. (Dec. 29, 2014, 2:24 p.m.)
```
Nilay, would you by any chance be able to push this?
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Change Summary:

Diff:

Change Summary:

Diff:

Status: Closed (submitted)