Review Board 2.0.15


Cagdas Dirik got review request #2552!

python: Adding event queue empty check after instantiation before startup

Review Request #2552 - Created Dec. 4, 2014 and updated

Information
Cagdas Dirik
gem5
Reviewers
Default 
This change adds an event queue empty check after instantiation. SimObjects that do self-initiated processing are expected to schedule internal events when startup() is called. There are modules which do not follow this guideline. And this creates issues with systemc version - especially when restoring from checkpoint. This change simply prints a warning message which is intended as a help in debugging failures.

   

  


 


 

  

  






 
 
Issue Summary

 

  

   
    
    1
   
   
    
    1
   
   
    
    0
   
   
    
    0
   
  

  

   

    
    
   

   

    
    
   

  

 

 

  

   
    

     Description
     From
     Last Updated
     Status
    

   
   







    

     I would suggest to make it fatal assuming all regressions pass
     Andreas Hansson
     Jan. 5, 2015, 3:25 p.m.
     Open
    








   
  

 









  
 


  

 
















 



 

  


 


  



   

   
Andreas Hansson

   
Posted  (Jan. 5, 2015, 3:25 p.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/python/m5/simulate.py
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
I would suggest to make it fatal assuming all regressions pass


     





 

  
  
  
  
  
  Show all issues
 




     




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Unfortunately cpu's are still posting events at t=0 right after instantiation. So changing it to fatal will fail a lot of tests. I do not have quick fix for cpu's. I prefer to keep it warn right now until we tidy it up a bit more.
    
    
    
   
    2. 

   


  


    


   



   
Could we perhaps change the keyword to "sim"? Also, is the summary line <65 char?

The description also looks like it needs to be wrapped at 80 char.