dev: Prevent intel 8254 timer events firing before startup

Information
Submitter:	Cagdas Dirik
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	abardsley, ahansson, ali

Description

This change includes edits to Intel8254Timer to prevent counter events firing before startup to comply with SimObject initialization call sequence.

Testing Done

Run regression tests. After downloading all ARM tests, all tests are passing except:
- EIO tests are skipped
- SPARC tests are failing due to missing insttest and m5threads-test
- X86 FS tests show changed stats.

Look good to me. Do the regressions still pass?

Cagdas Dirik Dec. 5, 2014, 8:48 a.m. (Dec. 5, 2014, 8:48 a.m.)

I ran the same tests as I mentioned in r/2545. Please let me know if I need to test more.

Cagdas Dirik Dec. 11, 2014, 9:32 p.m. (Dec. 11, 2014, 9:32 p.m.)

This very likely needs updates similar to r/2545 to carry the changes for alpha and mips. I am working on an update.

Cagdas Dirik Dec. 11, 2014, 10:16 p.m. (Dec. 11, 2014, 10:16 p.m.)

I have changes ready for alpha and mips, but they are on top of r/2545, and I don't know how to reflect that diff dependency here. So may be better to have r/2545 to be finished and submitted first. And then I will update this one.
Also I could not convince myself yet if src/dev/x86/speaker.* needs editing as well. It uses I8254 but it does not serialize/unserialize it, so I am not sure if it needs a timer->startup() call. This should also give me time to take a better look.

Nilay Vaish Jan. 3, 2015, 3:27 p.m. (Jan. 3, 2015, 3:27 p.m.)
```
What's the status of this patch?
```

Cagdas Dirik Jan. 5, 2015, 7:46 a.m. (Jan. 5, 2015, 7:46 a.m.)

I saw that r/2545 is submitted now - thank you. I have updates ready for this patch. Will prepare them shortly and update here, once I run regression tests.

Change Summary:

Updated to address regression issues with MIPS and Alpha.
Most of the regression tests pass. Some ARM tests are failing because vmlinux.aarch64.20140821 and vmlinux.aarch32.ll_20131205.0-gem5 are missing. And I cannot find these files anywhere in gem5.org. If someone can point me in their direction, I will greatly appreciate it.
Also some SPARC tests are failing because insttest files are missing. Again, where can I find these files?
X86 tests show changed timing. I am not sure if to waive this now, or it requires further update. Following the discussion on regression tests, this looks to be moving target.

Diff:

Revision 2 (+63 -14)

Show changes

	src/dev/intel_8254_timer.hh
	src/dev/intel_8254_timer.cc
	src/dev/alpha/tsunami_io.cc
	src/dev/mips/malta_io.cc
	src/dev/x86/i8254.hh
	src/dev/x86/i8254.cc

Change Summary:

Added details on testing done.

Testing Done:

	+	Run regression tests. After downloading all ARM tests, all tests are passing except:
	+	- EIO tests are skipped
	+	- SPARC tests are failing due to missing insttest and m5threads-test
	+	- X86 FS tests show changed stats.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Change Summary:

Diff:

Change Summary:

Testing Done:

Status: Closed (submitted)