misc: Generalize GDB single stepping.
Review Request #2556 - Created Dec. 5, 2014 and submitted
| Information | |
|---|---|
| Gabe Black | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10601:db4414e1e9a9 --------------------------- misc: Generalize GDB single stepping. The new single stepping implementation for x86 doesn't rely on any ISA specific properties or functionality. This change pulls out the per ISA implementation of those functions and promotes the X86 implementation to the base class. One drawback of that implementation is that the CPU might stop on an instruction twice if it's affected by both breakpoints and single stepping. While that might be a little surprising, it's harmless and would only happen under somewhat unlikely circumstances.
looks like a substantial improvement... visually seems fine but I haven't had a chance to actually test it yet.
Agreed, I'm a big fan of patches that are a net reduction in LOC, especially if there's no loss in functionality. I wouldn't be surprised if this is actually more robust too.