sim: Clean up InstRecord
Review Request #2561 - Created Dec. 10, 2014 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10610:67236857bfc6 --------------------------- sim: Clean up InstRecord Track memory size and flags as well as add some comments and consts.
Issue Summary
2
2
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Capitalization, execution => executing. The wording still makes it a little vague what the polarity of this flag means, but ... | Gabe Black | Dec. 10, 2014, 1:37 p.m. | Open |
| void on its own line. I don't think there's much to gain from squishing everything on one line like that. ... | Gabe Black | Dec. 10, 2014, 1:37 p.m. | Open |
Posted (Dec. 10, 2014, 1:37 p.m.)
-
src/sim/insttracer.hh (Diff revision 1) -
Yeah, that was always a pain. It made some things a lot harder to debug.
-
src/sim/insttracer.hh (Diff revision 1) -
Capitalization, execution => executing. The wording still makes it a little vague what the polarity of this flag means, but I think I got it. It would be nice if it could be clarified. Should a block style comment like this have anything on its first line? IE /* foo */ vs. /* * foo */
-
src/sim/insttracer.hh (Diff revision 1) -
void on its own line. I don't think there's much to gain from squishing everything on one line like that. But it's not the end of the world.
Ship It!