arm: Clean up and document decoder API
Review Request #2565 - Created Dec. 12, 2014 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10609:b11235acfc25 --------------------------- arm: Clean up and document decoder API This changeset adds more documentation to the ArmISA::Decoder class and restructures it slightly to make API groups more obvious.
Posted (Dec. 12, 2014, 2:21 p.m.)
-
src/arch/arm/decoder.hh (Diff revision 1) -
It's => It
-
src/arch/arm/decoder.hh (Diff revision 1) -
This isn't from your change and was probably originally done wrong by me, but could you please put the return type on its own line for these function definitions? Since you're touching everything already it seems like as good a time as any.
-
src/arch/arm/decoder.cc (Diff revision 1) -
If I'm remembering correctly, I think I put these in the .hh so that they could be easily inlined by callers, although I can't quite remember whether I wrote this originally or just think I did. It would be worthwhile seeing if it affects simulator performance.
Posted (Dec. 22, 2014, 12:18 p.m.)
I added a comment to this review, but since the issue had been marked resolved I don't know if it's going to send an email or not. Please take a look.