cpu: commit probe notification on every microop or macroop

Information
Submitter:	Nikos Nikoleris
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10646:f72bd92d39d2
---------------------------
cpu: commit probe notification on every microop or macroop

The ppCommit should notify the attached listener every time the cpu commits
a microop or non microcoded insturction. The listener can then decide 
whether it will process only the last microop (eg. SimPoint probe).

Testing Done

Description:

		Changeset 10646:f72bd92d39d2

		cpu: commit probe notification on every microop or macroop

		The ppCommit should notify the attached listener every time the cpu commits
~		either a microop or a macroop. The listener can then decide whether it will
~		process only the last microop or the macroop.
	~	a microop or non microcoded insturction. The listener can then decide
	~	whether it will process only the last microop (eg. SimPoint probe).

Ship It!

This will break GDB single stepping.

Nikos Nikoleris Jan. 14, 2015, 4:15 p.m. (Jan. 14, 2015, 4:15 p.m.)

If I undestand correctly, it won't be affected. When set, the GDB single step schedules the corresponding event at the comInstEventQueue. The comInstEventQueue services events using the Counter numInst which is incremented in BaseCPU class in the count function. The count function in its turn is called on every commit even if it's not the last microop but it checks if it is the last microop before it increments numInst.

If I am wrong and it does affect the single stepping, then I can change the patch. It would make more sense if the ppCommit probe notifies the listener with the macroop when the last microop is committed or the instruciton when it not macro coded.

Gabe Black Jan. 14, 2015, 5:49 p.m. (Jan. 14, 2015, 5:49 p.m.)
```
Oh, I think you're right. Never mind!
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 10646:f72bd92d39d2

Status: Closed (submitted)