cpu: o3 register renaming request handling improved
Review Request #2647 - Created Feb. 7, 2015 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10707:0872f196797d --------------------------- cpu: o3 register renaming request handling improved Now, prior to the renaming, the instruction requests the exact amount of registers it will need, and the rename_map decides whether the instruction is allowed to proceed or not.
Posted (Feb. 7, 2015, 10:34 a.m.)
-
src/cpu/base_dyn_inst.hh (Diff revision 1) -
given the author's penchant for alignment, I'm surprised there isn't another space before 'const' here
-
src/cpu/o3/rename_impl.hh (Diff revision 1) -
personally I'd format this as if (!renameMap[tid]->canRename(inst->numIntDestRegs(), inst->numFPDestRegs(), inst->numCCDestRegs())) { yea, it's an extra line, but the function call stands out more, and you get that nice symmetry across lines. I'm flexible though. -
src/cpu/o3/rename_map.hh (Diff revision 1) -
seems like 'unsigned' would be adequate here, esp. since the numFooRegs() fields are all int8_t at this point also not a huge deal, but to me it would be more readable to split the line between ')' and 'const', so at least all the params are on one line
Review request changed
Updated (Feb. 10, 2015, 9:43 a.m.)
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+17 -1) |