Review Board 2.0.15


Mem: Change the CLREX flag to CLEAR_LOCK.

Review Request #269 - Created Oct. 9, 2010 and submitted

Information
Gabe Black
gem5
Reviewers
Default 
Mem: Change the CLREX flag to CLEAR_LOCK.

CLREX is the name of an ARM instruction, not a name for this generic flag.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Ali Saidi

   
Posted  (Oct. 10, 2010, 1:01 p.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/mem/request.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
How about something more like CLEAR_LL or CLEAR_LLSC 




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Oh yeah, you're right. This is to clear the LLSC type of lock from Alpha, not the read-modify-write type of lock from X86. I guess I just had x86 stuck in my head. I like CLEAR_LL better since it's undoing that. The SC hasn't happened yet so it shouldn't be in the name. Barring any other suggestions or complaints I'll change it to that and commit it sometime soon.
    
    
    
   
    2.