Review Board 2.0.15


scons: specify swig binary filename in env

Review Request #2752 - Created April 30, 2015 and updated

Information
Ruslan Bukin
gem5
Reviewers
Default
ali, nilay 
Default swig binary filename in FreeBSD is 'swig2.0'

but build system only look for 'swig'.


This allows to specify correct name like:

export SWIG=/usr/local/bin/swig2.0
tested on FreeBSD only.
Review request changed
Updated (April 30, 2015, 6:44 a.m.)

Testing Done:
~  

tested on FreeBSD only

  ~

tested on FreeBSD only.
Nilay Vaish
Posted (May 4, 2015, 9:12 a.m.)



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          SConstruct
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
What happens differently here? Just looking at the code, I would assume that the operator [] behaves same as get() function.




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    [key] produce exception if there is no such key, get(key) returns None in such situation
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    Does that mean they should all use get? It seems odd to me that SWIG should be any different from the other build tools.
    
    
    
   
    3. 


   
  3. 
    
    
     
    
      
     
    
     
    yes, make sense
    
    
    
   
    4.