Review Board 2.0.15


MIPS: Get rid of the backdoor device copy/pasted from and only used in Alpha.

Review Request #276 - Created Oct. 16, 2010 and submitted

Information
Gabe Black
gem5
Reviewers
Default 
MIPS: Get rid of the backdoor device copy/pasted from and only used in Alpha.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  




   
Ship it!



   

   
Nathan Binkert

   
Posted  (Oct. 17, 2010, 2:29 p.m.)


  


  


  

   
I personally don't think you need to submit diffs for stuff like this.



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    I did for two reasons.

1. My experience with reviews at VMware was that everything, no matter how stupid, got reviewed, so that's my instinct. I realize the overhead is probably not warranted here, so I'll try to set a higher bar as far as review-worthiness.
2. Since this was an MIPS change, I wanted to give Korey a chance to object. I'll assume, unless Korey lets me know otherwise, that MIPS changes that don't break the regressions and that I have good faith belief don't break anything else can just go in.
    
    
    
   
    2.