kvm, x86: Guard x86-specific APIs in KvmVM

Download Diff
View Diff

Information
Submitter:	Andreas Sandberg
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10837:40beaa8357a6
---------------------------
kvm, x86: Guard x86-specific APIs in KvmVM

Protect x86-specific APIs in KvmVM with compile-time guards to avoid
breaking ARM builds.

Testing Done

ARM regressions pass. All backends build. Tested building with KVM support on x86 and ARMv8.

Expand All
Collapse All

src/cpu/kvm/vm.hh (Diff revision 1)

Would it be useful/cleaner to specialize this class for x86 and move CPUIDVector, MSRIndexVector and getSupportedCPUID into the derived class?

Andreas Sandberg May 19, 2015, 9:36 a.m. (May 19, 2015, 9:36 a.m.)

Yes, definitely. That's something I'd like to do at some point (I have started a couple of times, but never ended up with a solution I liked). Would you be OK with me leaving that for a later patch?

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)