kvm: Fix dumping code for large registers

Information
Submitter:	Andreas Sandberg
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10842:76dfb2247969
---------------------------
kvm: Fix dumping code for large registers

The register dumping code in kvm tries to print the bytes in large
registers (128 bits and larger) instead of printing them as hex. This
changeset fixes that.

Testing Done

ARM regressions pass. All backends build. Register dumping tested on ARMv8.

src/cpu/kvm/base.cc (Diff revision 1)

Instead of csprintf, would std::setbase(16) be a better choice here?

Steve Reinhardt May 19, 2015, 9:58 a.m. (May 19, 2015, 9:58 a.m.)

actually we prefer to move away from c++ streams and use the cprintf functions more, since it's more uniform and you don't have to worry about resetting state.  So I'd prefer to see this change to

    ccprintf(ss, "[0x%x", value[0]);

    for (int i = 1; i < len  / 8; ++i)

            ccprintf(ss, ", 0x%x", value[i]);

    ccprintf(ss, "]");

Description:

~		Changeset 10838:27644550a9ac
	~	Changeset 10842:76dfb2247969

		kvm: Fix dumping code for large registers

		The register dumping code in kvm tries to print the bytes in large
		registers (128 bits and larger) instead of printing them as hex. This
		changeset fixes that.

Diff:

Revision 2 (+8 -8)

Show changes

src/cpu/kvm/base.cc

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 10838:27644550a9ac

Changeset 10842:76dfb2247969

Diff:

Status: Closed (submitted)