slicc: isinstance bugfix

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10832:c3db4307f5e4
---------------------------
slicc: isinstance bugfix

This fix prevents spurious errors when searching for a symbol that may be
located in one of multiple symbol tables.

Testing Done

Please the read the discussion we had for this patch before: http://reviews.gem5.org/r/1620/.  I still think this is a bad idea.

Brad Beckmann May 13, 2015, 9:39 a.m. (May 13, 2015, 9:39 a.m.)

I don't quite understand your resistence. This patch only provides more flexibility in naming. It won't allow two variables with the same id.

Brad Beckmann May 28, 2015, 3:56 p.m. (May 28, 2015, 3:56 p.m.)

On 5/13 Nilay said "The flexibility is not required. We all have written lots of code in several different languages where this flexibility does not exist. I am against adding things to a language that are not required. I will say the same thing that I said in a different mail: if my code is broken, I would not try to fix the compiler."

The code that uses this functionality is not broken. This feature does not break any existing code. It only helps the programmer. The benefits certainly outweigh any costs, which appears to be rather minimal.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)