syscall: Add readlink to x86 with special case /proc/self/exe

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10811:9b5e672fbb47
---------------------------
syscall: Add readlink to x86 with special case /proc/self/exe

This patch implements the correct behavior.

Testing Done

Why do we need this special case?

Shuai Che May 14, 2015, 4:48 p.m. (May 14, 2015, 4:48 p.m.)

This case is used to get the application current running path.

Nilay Vaish May 15, 2015, 7:39 a.m. (May 15, 2015, 7:39 a.m.)

If I have read the patch correctly, the behaviour now will be that 
current working directory is returned as a repsonse to 
readlink("/proc/self/exe"). I might be running gem5 from any directory. 
How do you know this is the path the application wants to know? 

a. Can you be more explicit on why you think this is the right behaviour?
b. Assuming this is the behavior we want, should we not append the
executable's name as well?

Tony Gutierrez May 21, 2015, 1:42 p.m. (May 21, 2015, 1:42 p.m.)
```
Fixed
```

Summary:

-	syscall: Add readlink to x86 with special case /proc/self/exe
+	syscall_emul: Add readlink to with special case /proc/self/exe

Description:

~		Changeset 10835:14e31dee1390
	~	Changeset 10838:76fcde446236

~		syscall: Add readlink to x86 with special case /proc/self/exe
	~	syscall_emul: Add readlink to with special case /proc/self/exe

~		This patch implements the correct behavior.
	~	when reading from /proc/self/exe readlink will return the path where the
	+	gem5 binary is. this patch fixes this, allowing binaries to read their own
	+	path.

Diff:

Revision 2 (+37 -14)

Show changes

	src/arch/x86/linux/process.cc
	src/sim/syscall_emul.cc

Description:

~		Changeset 10838:76fcde446236
~
~		syscall_emul: Add readlink to with special case /proc/self/exe
	~	Changeset 10838:76fcde446236
	~	---------------------------
	~	syscall_emul: Add readlink with special case /proc/self/exe

		when reading from /proc/self/exe readlink will return the path where the
		gem5 binary is. this patch fixes this, allowing binaries to read their own
		path.

Summary:

-	syscall_emul: Add readlink to with special case /proc/self/exe
+	syscall: Add readlink to x86 with special case /proc/self/exe

Description:

~		Changeset 10838:76fcde446236
	~	Changeset 10811:9b5e672fbb47
		---------------------------
~		syscall_emul: Add readlink with special case /proc/self/exe
	~	syscall: Add readlink to x86 with special case /proc/self/exe

~		when reading from /proc/self/exe readlink will return the path where the
	~	This patch implements the correct behavior.
-		gem5 binary is. this patch fixes this, allowing binaries to read their own
-		path.

Diff:

Revision 3 (+29 -8)

Show changes

	src/arch/x86/linux/process.cc
	src/sim/syscall_emul.cc

Any comments on the updated patch?

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Changeset 10835:14e31dee1390

Changeset 10838:76fcde446236

Diff:

Description:

Changeset 10838:76fcde446236

Summary:

Description:

Diff:

Status: Closed (submitted)