slicc: improve support for prefix operations
Review Request #2791 - Created May 11, 2015 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10891:5d9dcfdd26b9 --------------------------- slicc: improve support for prefix operations This patch fixes the type handling when prefix operations are used. Previously prefix operators would assume a void return type, which made it impossible to combine prefix operations with other expressions. This patch allows SLICC programmers to use prefix operations more naturally.
Posted (May 12, 2015, 1:52 p.m.)
It seems we can have a table that maps an operator to the expected type. The code for checking and raising error need not be duplicated.
I agree in principle with Nilay, but since it's only 3 prefix operators I'm personally OK with it as is.
Review request changed
Updated (July 20, 2015, 10:43 a.m.)
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+15 -1) |
Ship It!