ruby: initalize replacement policies with their own simobjs
Review Request #2797 - Created May 11, 2015 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10898:521f2e2ae041
---------------------------
This is in preparation for other replacement policies that take aditional paramters
Ship It!
Any other comments on this one?
At a high-level, I like that you're breaking out the replacement policies this way. However, I really dislike that you have to add 3 new lines for every single controller you create in the config files. Not only is this kind of ugly since it's lots of replicated code, but it also affects all of us with our own protocols significantly.
I'll be able to spend some time tomorrow morning trying to come up with a reasonable solution (or decide it's impossible and give a "ship it" as is). It should be possible to encapsulate the duplicated code in the SimObject Python file.
Summary: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||
Diff: |
Revision 2 (+414 -177) |
Summary: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
Thanks for the changes!