Ruby: Updates MOESI Hammer protocol
Review Request #280 - Created Oct. 27, 2010 and submitted
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Ruby: Updates MOESI Hammer protocol This patch updates the MOESI Hammer protocol to conform with the new interfaces of CacheMemory and TBETable classes, and the changes in SLICC.
The changes have been tested using ruby_random_test.py for a 1,000,000 loads and 20 different seed values.
Review request changed
Updated (Dec. 31, 2010, 9:26 a.m.)
Change Summary:
As usual, I had forgotten to mention the option --git while executing the command 'hg qdiff' to generate the diff.
Diff: |
Revision 3 (+307 -235) |
|---|
Posted (Jan. 3, 2011, 2:19 a.m.)
-
src/mem/protocol/MOESI_hammer-cache.sm (Diff revision 3) -
There's a red blotch in reviewboard that I think is saying you have trailing space on this line.
-
src/mem/protocol/MOESI_hammer-cache.sm (Diff revision 3) -
More functions where it would be nice to identify the one valid entry_ptr up front rather than passing all of the candidates in every time. Maybe this could even be pushed all the way back up to the set_cache_entry calls? I don't know enough about the protocols to know if that's feasible, but it sounds nice.
Review request changed
Updated (Jan. 16, 2011, 8:21 a.m.)
Summary: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||
Branch: |
|
||||||||||||
Diff: |
Revision 4 (+432 -277) |
Posted (Jan. 16, 2011, 11:28 p.m.)
-
src/mem/protocol/MOESI_hammer-cache.sm (Diff revision 4) -
Don't just comment out these lines. You should replace them with equivalent lines, such as: assert((is_valid(getL1DCacheEntry(addr) && is_valid(getL1ICacheEntry(add)) == false); ...etc. Since they are within the assert call, they should be compiled out for the ".fast" binary.