slicc: support for arbitrary DPRINTF flags (not just RubySlicc)

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10832:cddb1f164072
---------------------------
slicc: support for arbitrary DPRINTF flags (not just RubySlicc)

This patch allows DPRINTFs to be used in SLICC state machines similar to how
they are used by the rest of gem5.  Previously all DPRINTFs in the .sm files
had to use the RubySlicc flag.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Is the function 4 lines below not enough?	Nilay Vaish	May 14, 2015, 5:22 p.m.	Resolved
Do you need this to be explicitly added? Shouldn't is automatically be added when someone uses a DPRINTF with this ...	Jason Lowe-Power	July 22, 2015, 2:35 p.m.	Resolved

src/mem/slicc/ast/VarExprAST.py (Diff revision 1)

Is the function 4 lines below not enough?

Show all issues

Brad Beckmann May 14, 2015, 9:14 a.m. (May 14, 2015, 9:14 a.m.)

Thats a good question.  After some investigation, I've determined that since the name() function is a property function, it returns a read only variable that cannot be converted to a string.  I believe the actual VarExtAST.name() will generate an error whenever it is called, so we should probably just remove it.
Perhaps someone who is more familary with python @property can confirm.

Description:

~		Changeset 10857:cde98a38fced
	~	Changeset 10832:13b9f3eb5944

		slicc: support for arbitrary DPRINTF flags (not just RubySlicc)

		This patch allows DPRINTFs to be used in SLICC state machines similar to how
		they are used by the rest of gem5. Previously all DPRINTFs in the .sm files
		had to use the RubySlicc flag.

Diff:

Revision 2 (+31 -8)

Show changes

	src/mem/slicc/ast/FuncCallExprAST.py
	src/mem/slicc/ast/VarExprAST.py
	src/mem/slicc/symbols/StateMachine.py

Description:

~		Changeset 10832:13b9f3eb5944
	~	Changeset 10832:cddb1f164072

		slicc: support for arbitrary DPRINTF flags (not just RubySlicc)

		This patch allows DPRINTFs to be used in SLICC state machines similar to how
		they are used by the rest of gem5. Previously all DPRINTFs in the .sm files
		had to use the RubySlicc flag.

Diff:

Revision 3 (+30 -8)

Show changes

	src/mem/slicc/ast/FuncCallExprAST.py
	src/mem/slicc/symbols/StateMachine.py

Ship It!

Other than the small thing below.

src/mem/slicc/symbols/StateMachine.py (Diff revision 3)

Do you need this to be explicitly added? Shouldn't is automatically be added when someone uses a DPRINTF with this flag?

I see why RubyGenerated needs to be here, but I don't believe any generated code uses RubySlicc (with a cursory grep).

Show all issues

Tony Gutierrez July 22, 2015, 2:36 p.m. (July 22, 2015, 2:36 p.m.)
```
You're right. Fixed.
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 10857:cde98a38fced

Changeset 10832:13b9f3eb5944

Diff:

Description:

Changeset 10832:13b9f3eb5944

Changeset 10832:cddb1f164072

Diff:

Status: Closed (submitted)