ruby: fix deadlock bug in banked array resource checks
Review Request #2806 - Created May 11, 2015 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10863:afeee121918e --------------------------- ruby: fix deadlock bug in banked array resource checks The Ruby banked array resource checks (initiated from SLICC) did a check and allocate at the same time. If a transition needs more than one resource, then it might check/allocate resource #1, then fail to get resource #2. Another transition might then try to get the same resources, but in reverse order. Deadlock. This patch separates resource checking and resource reservation into two steps to avoid deadlock.
LGTM. The bank reservation/checking logic looks like it could use a revamping after the clock domain updates, but that's for another day, and another patch.
Posted (May 19, 2015, 1:48 p.m.)
Any more comments on this patch?
