ruby: change router pipeline stages to 2
Review Request #2809 - Created May 11, 2015 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10842:f30297943d77 --------------------------- ruby: change router pipeline stages to 2 This patch changes the router pipeline stages from 4 to 2. The canonical 4-stage router is conservative while a lower-latency router with look ahead routing and speculative allocation is well acknowledged.
Posted (May 12, 2015, 2:24 p.m.)
-
src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh (Diff revision 1) -
Suppose, you need to add two cycles, would you write a function advance_stage_two_cycles()? Write a separate patch that changes the function advance_stage() so that it sets m_stage.second to the second parameter of the function. Then, change every single place where advance_stage is called and add a cycle to the argument being passed. In this patch (2809), remove that cycle from being added.
Review request changed
Updated (May 26, 2015, 1:08 p.m.)
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+36 -15) |
Posted (June 2, 2015, 5:23 p.m.)
Any more comments on this patch?
Posted (July 2, 2015, 11:39 a.m.)
We're planning to push this patch soon. Any other comments?