slicc: enable overloading in functions not in classes

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10843:8851306e9602
---------------------------
slicc: enable overloading in functions not in classes

For many years the slicc symbol table has supported overloaded functions in
external classes.  This patch extends that support to functions that are not
part of classes (a.k.a. no parent).  For example, this support allows slicc
to understand that mapAddressToRange is overloaded and the NodeID is an
optional parameter.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Can you explain what this statement is doing? Please avoid adding such special cases.	Nilay Vaish	May 11, 2015, 9:08 p.m.	Open

Again, I would like to know what behaviour is this change trying to achieve?

Brad Beckmann May 12, 2015, 4:58 p.m. (May 12, 2015, 4:58 p.m.)

What more do I need to say beyond what the description already says? It allows us to overload global functions, such as those used for mapping. SLICC already supports overloading for classes. This patch just completes the overloading support.

src/mem/slicc/symbols/Transition.py (Diff revision 1)

Can you explain what this statement is doing?  Please avoid adding such special cases.

Show all issues

Brad Beckmann May 12, 2015, 4:58 p.m. (May 12, 2015, 4:58 p.m.)

I'm not sure I follow this comment/question.  First, SLICC is full of special cases.  Secondly, I'm not even introducing a new special case.  I'm just improving the already existing test to make sure that the needed getNextState function uses an Address as an input parameter.
Please note that to support overloading, the function id is the combination of the function name and input parameters separated by underscores.

Seems reasonable to me. But why not just go the whole way and implement true name mangling. (Joking!)

Are there any more comments on this patch?

Nilay Vaish May 19, 2015, 6:34 p.m. (May 19, 2015, 6:34 p.m.)

Overall I am fine with the patch. I think there are places where there is no space
between the operator '+' and its operands.

Nilay Vaish May 19, 2015, 6:35 p.m. (May 19, 2015, 6:35 p.m.)

I forgot to say one thing. Since I am going to insist on getNextState() being
dropped altogether, it should be dropped from this patch as well.

Ship It!

Description:

~		Changeset 10867:5de130c7b15d
	~	Changeset 10843:8851306e9602

		slicc: enable overloading in functions not in classes

		For many years the slicc symbol table has supported overloaded functions in
		external classes. This patch extends that support to functions that are not
		part of classes (a.k.a. no parent). For example, this support allows slicc
		to understand that mapAddressToRange is overloaded and the NodeID is an
		optional parameter.

Diff:

Revision 2 (+39 -16)

Show changes

	src/mem/protocol/RubySlicc_ComponentMapping.sm
	src/mem/slicc/ast/EnumDeclAST.py
	src/mem/slicc/ast/FuncCallExprAST.py
	src/mem/slicc/ast/FuncDeclAST.py
	src/mem/slicc/ast/InPortDeclAST.py
	src/mem/slicc/ast/StateDeclAST.py
	src/mem/slicc/symbols/Func.py
	src/mem/slicc/symbols/Transition.py

I think all the review comments are taken care now. Any more comments?

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 10867:5de130c7b15d

Changeset 10843:8851306e9602

Diff:

Status: Closed (submitted)