Backing store: Serialize/unserialize backing store
Review Request #2812 - Created May 11, 2015 and discarded
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10869:9c32bcb74db9 --------------------------- Backing store: Serialize/unserialize backing store While using backing store, serialize/unserialize backing store.
Issue Summary
1
1
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| I'm not clear why it is necessary to serialize/unserialize m_phys_mem. It is a SimpleMemory object, which inherits the empty serialize/unserialize ... | Joel Hestness | May 12, 2015, 7:15 a.m. | Open |
Posted (May 11, 2015, 9:15 p.m.)
Would not serialize() and unserialize() get called automatically?
Posted (May 12, 2015, 7:15 a.m.)
-
src/mem/ruby/system/System.cc (Diff revision 1) -
I'm not clear why it is necessary to serialize/unserialize m_phys_mem. It is a SimpleMemory object, which inherits the empty serialize/unserialize functions from Serializable. All the serialize function will do is write the system.ruby.phys_mem header to the checkpoint. No other state is stored as a result of this call. Am I missing something?
I also prompted this on a prior review request here, but didn't receive a response: http://reviews.gem5.org/r/2627/
