ruby: Changes to support finite buffering in ruby.
Review Request #2814 - Created May 11, 2015 and discarded
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10846:3d8b972ce367 --------------------------- ruby: Changes to support finite buffering in ruby. Adds code in controller generating python code to initialize message buffers with a size specified in the SLICC definition of of the controller's buffer. This allows all message buffers including mandatory queues to use finite buffering. Additionally adds code to properly check the resource constraints for an action with respect to the entries available in a controller's network buffers in the case that multiple buffers are defined to map to the same virtual network. Previously this case would cause multiple resource checks to see if a single entry was available, rather than one check to see if multiple entries were available.
Issue Summary
| Description | From | Last Updated | Status |
|---|---|---|---|
| This code appears to be replicated from review 2801 ( http://reviews.gem5.org/r/2801/ ). It looks like this code should be in ... | Joel Hestness | May 14, 2015, 11:14 a.m. | Open |
You need to provide example of what this change is trying to achieve. Personally, if wanted buffers to have a size, I would want to that size to be configurable in python.
Cool! Brad, you were telling me at least 4 years ago you wanted this ;).
I agree that it would be good if we could control the buffer sizes from Python, and I don't think it would take too much effor, as Mark said. Seems appropriate for a future patch, though, when someone needs that feature.
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 1) -
This code appears to be replicated from review 2801 ( http://reviews.gem5.org/r/2801/ ). It looks like this code should be in that patch instead of here, and this code also needs to handle var["buffer_size"] types more appropriately.
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+56) |
