ruby: expose access permission to replacement policies
Review Request #2824 - Created May 11, 2015 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10839:d3f20078bf20 --------------------------- ruby: expose access permission to replacement policies This patch adds support that allows the replacement policy to identify each cache block's access permission. This information can be useful when making replacement decisions.
Issue Summary
| Description | From | Last Updated | Status |
|---|---|---|---|
| The tabs for these two lines aren't the correct width. | Joel Hestness | May 12, 2015, 7:45 a.m. | Open |
| Couple things here: 1) This member variable should not be public, but should be moved into the protected code section ... | Joel Hestness | May 12, 2015, 7:45 a.m. | Open |
| Function parameters are lower_underscore format throughout this file. This affects these two lines, as well as the function declarations in ... | Joel Hestness | May 12, 2015, 7:45 a.m. | Open |
| Curly braces should be used consistently with the rest of the file. | Joel Hestness | May 12, 2015, 7:45 a.m. | Open |
-
src/mem/ruby/structures/AbstractReplacementPolicy.hh (Diff revision 1) -
The tabs for these two lines aren't the correct width.
-
src/mem/ruby/structures/AbstractReplacementPolicy.hh (Diff revision 1) -
Couple things here:
1) This member variable should not be public, but should be moved into the protected code section
2) There isn't any precedent for using "class" in function or member declarations in gem5. I'd recommend forward declaring class CacheMemory at the beginning of the file to be consistent with other gem5 code that needs to avoid circular header includes. Then, remove "class" from these two lines. -
src/mem/ruby/structures/CacheMemory.hh (Diff revision 1) -
Function parameters are lower_underscore format throughout this file. This affects these two lines, as well as the function declarations in the other two files.
-
src/mem/ruby/structures/CacheMemory.cc (Diff revision 1) -
Curly braces should be used consistently with the rest of the file.
In addition to Joel's style comments, the commit message has a spelling error: premission->permission.
As long as all the syntax fixes were incorporated.
Summary: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 2 (+20) |
-
src/mem/ruby/structures/AbstractReplacementPolicy.hh (Diff revision 2) -
Can you please use consistent spacing around curly braces (see two lines above this)?
-
src/mem/ruby/structures/AbstractReplacementPolicy.hh (Diff revision 2) -
Should this pointer should be private? The replacement policy's parent class will have a pointer to the same cache, so it need not be able to publicly access the pointer in the replacement policy.