Review Board 2.0.15


cpu: o3: Commit stage updates for hw threads priority list

Review Request #2856 - Created May 28, 2015 and updated

Information
Alexandru Dutu
gem5
default
Reviewers
Default 
Changeset 10862:c32578991199
---------------------------
cpu: o3: Commit stage updates for hw threads priority list
This patch makes sure the priority_list in the fetch stage is kept in sync
with suspendContext and activateContext calls.
Quick regressions passed for all ISAs.

Issue Summary

1 1 0 0
Description From Last Updated Status
Why do we have different names for the functions called on Fetch and Commit stages? Nilay Vaish June 20, 2015, 11:18 p.m. Open
Nilay Vaish
Posted (June 20, 2015, 11:18 p.m.)



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/cpu/o3/cpu.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Why do we have different names for the functions called on Fetch and Commit stages?


     





 

  
  
  
  
  
  Show all issues
 




     




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    For the fetch stage there already was a function which was handleing status update, however just for thread 0. So that function needed to be updated and I kept the name. For commit there is no notion of a quiesce state, so I chose a different name that makes sense for this stage.
    
    
    
   
    2. 

   


  


    


   



  

 


  

 

















 



 

  


 


  




   
Ship it!



   

   
Andreas Sandberg

   
Posted  (June 23, 2015, 2:14 a.m.)


  


  


  

   
I'm happy with this.

I agree with Nilay that the difference in naming is a bit unfortunate. It'd probably make sense to rename the methods in fetch so they use the suspend/activate terminology and implement quiesce using that. That's a different commit though.