dev, arm: Add a device model that uses the NoMali model

Information
Submitter:	Andreas Sandberg
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10887:ef663bf9825b
---------------------------
dev, arm: Add a device model that uses the NoMali model

Add a simple device shim that interfaces with the NoMali model
library. The gem5 side of the interface supports Mali T60x/T62x/T760
GPUs. This device model pretends to be a Mali GPU, but doesn't render
anything and executes in zero time.

Testing Done

Issue Summary

Description	From	Last Updated	Status
_HH_	Nilay Vaish	June 21, 2015, 12:10 p.m.	Resolved
bool set.	Nilay Vaish	June 21, 2015, 12:11 p.m.	Dropped
This will never evaluate to true since size == 4 here.	Nilay Vaish	June 21, 2015, 12:13 p.m.	Resolved
Same comment as above.	Nilay Vaish	June 21, 2015, 12:13 p.m.	Resolved

src/dev/arm/gpu_nomali.hh (Diff revision 1)

Show all issues

src/dev/arm/gpu_nomali.hh (Diff revision 1)

bool set.

Show all issues

Andreas Sandberg June 21, 2015, 12:52 p.m. (June 21, 2015, 12:52 p.m.)

This can't be changed to set since this signature is defined in the NoMali C library.

src/dev/arm/gpu_nomali.hh (Diff revision 1)

Since we are in file that is for nomali, I would like to call this variable just info.

Andreas Sandberg June 21, 2015, 12:52 p.m. (June 21, 2015, 12:52 p.m.)

I'd prefer not to do that since that would be a pretty generic name that could easily alias with global functions.

src/dev/arm/gpu_nomali.hh (Diff revision 1)

Maybe rename the variable to handle or libHandle or something similar.

src/dev/arm/gpu_nomali.cc (Diff revision 1)

This will never evaluate to true since size == 4 here.

Show all issues

Andreas Sandberg June 21, 2015, 12:52 p.m. (June 21, 2015, 12:52 p.m.)

Thanks! That was supposed to be addr (i.e., check that addr is 4-byte aligned) and not size.

src/dev/arm/gpu_nomali.cc (Diff revision 1)

Same comment as above.

Show all issues

Description:

~		Changeset 10869:2222689a52b3
	~	Changeset 10887:ef663bf9825b

		dev, arm: Add a device model that uses the NoMali model

		Add a simple device shim that interfaces with the NoMali model
		library. The gem5 side of the interface supports Mali T60x/T62x/T760
		GPUs. This device model pretends to be a Mali GPU, but doesn't render
		anything and executes in zero time.

Diff:

Revision 2 (+463)

Show changes

	src/dev/arm/NoMali.py
	src/dev/arm/SConscript
	src/dev/arm/gpu_nomali.hh
	src/dev/arm/gpu_nomali.cc

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 10869:2222689a52b3

Changeset 10887:ef663bf9825b

Diff:

Status: Closed (submitted)