dev, x86: Fix serialization bug in the i8042 device

Information
Submitter:	Andreas Sandberg
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10919:c83fe54a7ff7
---------------------------
dev, x86: Fix serialization bug in the i8042 device

The i8042 device drops the contents of a PS2 device's buffer when
serializing, which results in corrupted PS2 state when continuing
simulation after a checkpoint. This changeset fixes this bug and
transitions the i8042 model to use the new serialization API that
requires the serialize() method to be const.

Testing Done

Tested taking checkpoints and restoring from checkpoints.

Seems fine to me. Any reason you switched from queue to deque?

Andreas Sandberg July 13, 2015, 6:57 a.m. (July 13, 2015, 6:57 a.m.)

Elements in a normal queue can't be accessed without removing them from the queue, which isn't the case for a deque. This makes serialization simpler since we don't need to modify the queue in serialize().

Nilay Vaish July 13, 2015, 10:17 a.m. (July 13, 2015, 10:17 a.m.)
```
Thanks. I understand now.
```

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)