mem: Tidy up packet

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10921:8177ac19f549
---------------------------
mem: Tidy up packet

Some minor fixes and removal of dead code. Changing the flags to be
enums rather than static const (to avoid any linking issues caused by
the latter). Also adding a getBlockAddr member which hopefully can
slowly finds its way into caches, snoop filters etc.

Testing Done

src/mem/packet.hh (Diff revision 1)

Why drop this?

Andreas Hansson July 16, 2015, 2:56 p.m. (July 16, 2015, 2:56 p.m.)
```
It is never used. Perhaps Jason should have a look :-)
```

Jason Lowe-Power July 16, 2015, 3:04 p.m. (July 16, 2015, 3:04 p.m.)

Haha, I haven't either. Thanks for asking, though!

I do think we need to be careful just removing functions that seem unused, though I don't have a good alternative. Maybe mark it as deprecated until the next stable release? Or broadcast to the lists specifically asking about this function?
We ought to make some formal method here. When are we allowed to clean up functions like this? I don't know the answer.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)