style: change Process function calls to use camelCase
Review Request #2969 - Created July 13, 2015 and submitted
| Information | |
|---|---|
| Brandon Potter | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10920:4dc093946a01 \-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- style: change Process function calls to use camelCase The Process class methods were using an improper style and this subsequently bled into the system call code. The following regular expressions should be helpful if someone transitions private system call patches on top of these changesets: s/alloc_fd/allocFD/ s/sim_fd(/getSimFD(/ s/sim_fd_obj/getFDEntry/ s/fix_file_offsets/fixFileOffsets/ s/find_file_offsets/findFileOffsets/
Thanks for cleaning these up. Below are a couple suggestions, though not absolutely necessary.
-
src/sim/process.hh (Diff revision 1) -
Just a suggestion: Since we're changing these, would you mind making simFD more decriptive? Perhaps, getSimFD?
-
src/sim/process.hh (Diff revision 1) -
Just a suggestion: Similar, maybe getTgtFD?
Review request changed
Updated (July 20, 2015, 4 p.m.)
Description: |
|
|---|
Ship It!
