ruby: simple network: store Switch* in PerfectSwitch and Throttle

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11088:e4b173785c24
---------------------------
ruby: simple network: store Switch* in PerfectSwitch and Throttle
There are two reasons for doing so:

a. provide a source of clock to PerfectSwitch. A follow on patch removes sender
and receiver pointers from MessageBuffer means that the object owning the
buffer should have some way of providing timing info.

b. schedule events.  A follow on patch removes the consumer class.  So the
PerfectSwitch needs some EventManager object to schedule events on its own.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Is m_switch going to be used in a following patch? If not, can we leave it out for now?	Joel Hestness	Aug. 17, 2015, 8:30 a.m.	Resolved

Status: Closed (submitted)

src/mem/ruby/network/simple/PerfectSwitch.hh (Diff revision 1)

Is m_switch going to be used in a following patch? If not, can we leave it out for now?

Show all issues

Nilay Vaish Aug. 17, 2015, 8:30 a.m. (Aug. 17, 2015, 8:30 a.m.)

Required since PerfectSwitch does not have a clock of its own.
A later patch (http://reviews.gem5.org/r/2985/) that removes sender and receiver
pointers from MessageBuffer means that the object owning the buffer has some
way of providing timing info.

Status: Re-opened

Does any one has any comments on this patch?

Brad Beckmann Sept. 4, 2015, 4:38 p.m. (Sept. 4, 2015, 4:38 p.m.)

I don't have any problems with this patch, but I'm curious what is the motivation?

Nilay Vaish Sept. 4, 2015, 5:38 p.m. (Sept. 4, 2015, 5:38 p.m.)
```
I have updated the patch description.
```

Description:

~		Changeset 11033:540189ded5b8
	~	Changeset 11088:e4b173785c24

~		ruby: simple network: store Switch* in PerfectSwitch and Throttle
	~	ruby: simple network: store Switch* in PerfectSwitch and Throttle
	+	There are two reasons for doing so:
	+
	+	a. provide a source of clock to PerfectSwitch. A follow on patch removes sender
	+	and receiver pointers from MessageBuffer means that the object owning the
	+	buffer should have some way of providing timing info.
	+
	+	b. schedule events. A follow on patch removes the consumer class. So the
	+	PerfectSwitch needs some EventManager object to schedule events on its own.

Diff:

Revision 2 (+14 -30)

Show changes

	src/mem/ruby/network/simple/PerfectSwitch.hh
	src/mem/ruby/network/simple/PerfectSwitch.cc
	src/mem/ruby/network/simple/Throttle.hh
	src/mem/ruby/network/simple/Throttle.cc

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)

Status: Re-opened

Description:

Changeset 11033:540189ded5b8

Changeset 11088:e4b173785c24

Diff:

Status: Closed (submitted)