ruby: network: drop member m_in_use
Review Request #3011 - Created Aug. 9, 2015 and submitted
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11047:7d7ed2b7ecf6 --------------------------- ruby: network: drop member m_in_use This member indicates whether or not a particular virtual network is in use. Instead of having a default big value for the number of virtual networks and then checking whether a virtual network is in use, the next patch removes the default value and the protocol configuration file would now specify the number of virtual networks it requires.
Posted (Aug. 14, 2015, 2:51 p.m.)
-
src/mem/ruby/network/garnet/BaseGarnetNetwork.hh (Diff revision 1) -
I think these function header changes should be in a separate patch. If anyone has downstream patches that modify these functions, it may be tricky figuring out why these changes were made in this patch.
-
src/mem/ruby/network/garnet/flexible-pipeline/Router.cc (Diff revision 1) -
This change is orthogonal to the patch description. I think it's ok to be in this patch, but should be reflected in the description.
Posted (Aug. 27, 2015, 11:33 a.m.)
-
src/mem/ruby/network/garnet/flexible-pipeline/Router.cc (Diff revision 1) -
Same comment as Joel but I think this change should be another patch.
Ship it after addressing the comments.