util/decode_inst_dep_trace.py (Diff revision 1)

I read the code.  I think there is some inconsistency in the decoding and the encoding procedures.  Typically, the procedures should look like inverses of each other.


When you are writing addr, size and flags, the code in encoding and decoding differs.


PC and weight are not optional in the ascii trace.  You write some default values.

Show all issues

1. Andreas Hansson Sept. 21, 2015, 8:06 a.m. (Sept. 21, 2015, 8:06 a.m.)

   I'd just like to point out that the goal here is not to encode/decode protobuf traces to/from ASCII. The decoder is essentially only there to make the trace human readable (and the encoder to be able to create tiny synthetic examples). There is really no value in having two trace formats...

2. Radhika Jagtap Nov. 5, 2015, 11:15 a.m. (Nov. 5, 2015, 11:15 a.m.)

   That's exactly right. The ASCII file format will always output a default (0 for PC, 1 for weight). I believe this is more human readbale (was to me) than having to figure whether or not this optional value is present. For LOAD or STORE (the enums added in http://reviews.gem5.org/r/3089/) make it quick to spot the addr, size, flags.

Ship It!