ruby: Use the const serialize interface in RubySystem

Information
Submitter:	Andreas Sandberg
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11049:f2dc54dbf12d
---------------------------
ruby: Use the const serialize interface in RubySystem

The new serialization code (kudos to Tim Jones) moves all of the state
mangling in RubySystem to memWriteback. This makes it possible to use
the new const serialization interface.

This changeset moves the cache recorder cleanup from the checkpoint()
method to drainResume() to make checkpointing truly constant and
updates the checkpointing code to use the new interface.

Testing Done

Regressions pass.

Ship It!

This change seems pretty straightforward. Did you actually test checkpoint/restore with Ruby? I don't think any of the regressions test it.

Andreas Sandberg Aug. 26, 2015, 9:25 a.m. (Aug. 26, 2015, 9:25 a.m.)

Well, I tried... At least in the revision I have checked out, I couldn't checkpoint Ruby without the patch. The good news is that I get the same panic (Runtime Error at MI_example-cache.sm:126: Invalid RubyRequestType.) with the patch.

Jason Lowe-Power Aug. 26, 2015, 9:27 a.m. (Aug. 26, 2015, 9:27 a.m.)

I think MOESI_hammer is the only protocol that supports checkpointing. At least, it definitely does support it. I'll try to take it on myself to update the docs about this.

Andreas Sandberg Aug. 26, 2015, 9:41 a.m. (Aug. 26, 2015, 9:41 a.m.)

Hmm, OK, that was a bit unexpected. I just ran some tests with ALPHA_MOESI_hammer and things seem to work (I'm able to checkpoint and restore and a trace is generated).

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)