sim: Get rid of the non-const serialize() method

Information
Submitter:	Andreas Sandberg
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11050:f7968cfeb491
---------------------------
sim: Get rid of the non-const serialize() method

The last SimObject using the legacy serialize API with non-const
methods has now been transitioned to the new API. This changeset
removes the serializeOld() methods from the serialization base class
as they are no longer used.

Testing Done

Regressions pass.

Any chance of keeping this deprecated across a gem5-stable branch? I'm just throwing the idea out there. It seems checkpointing would have broken already since the name changed. Also, I have no idea what the current state of gem5-stable is, so maybe this has already happened.

Andreas Sandberg Aug. 26, 2015, 9:44 a.m. (Aug. 26, 2015, 9:44 a.m.)

This is certainly something that we could do. However, I'm not sure if there is any easy way of generating a deprecation warning if the old interface is used.

Is there code in your gem5 branch that depends on this functionality?

Jason Lowe-Power Aug. 26, 2015, 9:47 a.m. (Aug. 26, 2015, 9:47 a.m.)

No, I don't think so. I agree that with the -Old name that there is no easy way of generating a warning. I'm for committing this as is and maybe next time trying to be more careful about having a deprecation warning. I've been puching things this way, but we should decide as a community how we want to deprecate, and what we want to deprecate.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)