ruby: perfect switch: refactor code

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11069:e83d2f2cbb57
---------------------------
ruby: perfect switch: refactor code
Refactored the code in operateVnet(), moved partly to a new function
operateMessageBuffer(). This is required since a later patch moves to having a
wakeup event per MessageBuffer instead of one event for the entire Switch.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Do you foresee this function being used outside of the "operateVnet" function? If not, I don't understand the need for ...	Jason Lowe-Power	Sept. 9, 2015, 11:55 a.m.	Dropped

Any comments on this patch? I am planning to push it at the end of the week.

src/mem/ruby/network/simple/PerfectSwitch.cc (Diff revision 1)

Do you foresee this function being used outside of the "operateVnet" function? If not, I don't understand the need for this change.

Show all issues

Nilay Vaish Sept. 9, 2015, 11:46 a.m. (Sept. 9, 2015, 11:46 a.m.)

We will be removing the operateMessageBuffer() function altogether in a later patch.

Take look at: reviews.gem5.org/r/2987

Jason Lowe-Power Sept. 9, 2015, 11:55 a.m. (Sept. 9, 2015, 11:55 a.m.)

Ah, I didn't catch that one. I guess I'm OK with this patch, but only when the other is submitted.

Nilay Vaish Sept. 9, 2015, 12:25 p.m. (Sept. 9, 2015, 12:25 p.m.)
```
I have updated the description for the patch.
```

Once http://reviews.gem5.org/r/2987/ is submitted.

Description:

~		Changeset 11069:e83d2f2cbb57
~
~		ruby: perfect switch: refactor code
	~	Changeset 11069:e83d2f2cbb57
	~	---------------------------
	~	ruby: perfect switch: refactor code
		Refactored the code in operateVnet(), moved partly to a new function
~		operateMessageBuffer().
	~	operateMessageBuffer(). This is required since a later patch moves to having a
	+	wakeup event per MessageBuffer instead of one event for the entire Switch.

Splitting these functions up is generally a good thing. There shouldn't be many conflicts with this patch.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 11069:e83d2f2cbb57

Status: Closed (submitted)