base: remove Trace::enabled flag
Review Request #3082 - Created Aug. 31, 2015 and submitted
| Information | |
|---|---|
| Curtis Dunham | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
The DTRACE() macro tests both Trace::enabled and the specific flag. This
change uses the same administrative interface for enabling/disabling
tracing, but masks the SimpleFlags settings directly. This eliminates a
load for every DTRACE() test, e.g. DPRINTF.This functionality was not and remains not threadsafe.
On ARM quick regressions, runtime reductions of up to 18% were observed.
Any objections?
Looks fine to me. I assume Nate wrote all this code originally, so it would be interesting to hear from him, but no need to wait for that to happen.
What is the use case for having the global enable/disable flag anyway? Is this how --trace-start is implemented? Other than that I can't even think of a use for it.
Oops, forgot to click the box.