ruby: slicc: remove nextLineHack from Type.py

Download Diff
View Diff

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11078:249cacaa1d02
---------------------------
ruby: slicc: remove nextLineHack from Type.py

Testing Done

Expand All
Collapse All

Do you know what this was used for? I've never encountered this, but it probably had a good reason to be there at some point...

Nilay Vaish Sept. 2, 2015, 9:18 p.m. (Sept. 2, 2015, 9:18 p.m.)

None of the current protocols use it. The line has seen not any changes since SLICC was first
merged into the repository. I certainly don't like the name of the 'feature'. I think
it is safe to drop it.

Jason Lowe-Power Sept. 3, 2015, 7:02 a.m. (Sept. 3, 2015, 7:02 a.m.)

At a minimum we should wait for Brad to comment, since he may know what its purpose was.

Brad Beckmann Sept. 4, 2015, 1:55 p.m. (Sept. 4, 2015, 1:55 p.m.)

I believe this feature was used by my old DNUCA protocol (cira 2003). I'm happy to see it go.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)